Skip to content

profiling: bump chunk interval to 60s #15361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2025
Merged

profiling: bump chunk interval to 60s #15361

merged 2 commits into from
Feb 18, 2025

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Feb 10, 2025

Bump profiling chunk interval to 60s as per spec

@JonasBa JonasBa requested a review from AbhiPrasad February 10, 2025 20:00
@codecov
Copy link

codecov bot commented Feb 10, 2025 •
edited
Loading

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
56 3 53 0
View the top 3 failed test(s) by shortest run time 
continuous profiling chunks share the same profilerId
Stack Traces | 0.001s run time 
Error: expect(jest.fn()).toHaveBeenCalledTimes(expected)

Expected number of calls: 1
Received number of calls: 0
    at Object.<anonymous> (.../profiling-node/test/spanProfileUtils.test.ts:522:30)
    at Promise.then.completed (.../jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:316:10)
    at _callCircusTest (.../jest-circus/build/run.js:218:40)
    at _runTest (.../jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:66:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:60:9)
    at run (.../jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
continuous profiling restarts a new chunk after previous
Stack Traces | 0.002s run time 
Error: expect(jest.fn()).toHaveBeenCalledTimes(expected)

Expected number of calls: 1
Received number of calls: 0
    at Object.<anonymous> (.../profiling-node/test/spanProfileUtils.test.ts:505:30)
    at Promise.then.completed (.../jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:316:10)
    at _callCircusTest (.../jest-circus/build/run.js:218:40)
    at _runTest (.../jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:66:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:60:9)
    at run (.../jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
continuous profiling stops a continuous profile after interval
Stack Traces | 0.002s run time 
Error: expect(jest.fn()).toHaveBeenCalledTimes(expected)

Expected number of calls: 1
Received number of calls: 0
    at Object.<anonymous> (.../profiling-node/test/spanProfileUtils.test.ts:556:30)
    at Promise.then.completed (.../jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:316:10)
    at _callCircusTest (.../jest-circus/build/run.js:218:40)
    at _runTest (.../jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:66:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:60:9)
    at run (.../jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@JonasBa JonasBa merged commit da8ba8d into develop Feb 18, 2025
29 checks passed
@JonasBa JonasBa deleted the jb/profiling/chunk-size-increase branch February 18, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timfish timfish timfish approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JonasBa @timfish